App layout refactor: Phase 2 - #6599
Open
RobertJoonas wants to merge 5 commits into
Open
Conversation
4 tasks
aerosol
reviewed
Aug 15, 2026
| PlausibleWeb.Router.Helpers.static_path( | ||
| @conn, | ||
| logo_path("logo_dark.svg") | ||
| PlausibleWeb.Endpoint, |
Member
There was a problem hiding this comment.
is there a specific difference between using Endpoint and @conn here?
| """ | ||
| end | ||
|
|
||
| def legacy(assigns) do |
Member
There was a problem hiding this comment.
For this component and others, shall we enumerate the attrs+defaults for each for better compile-time hygiene?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
See phase 1 PR for full context.
Layouts.appcomponent: typed attrs (header?,footer?,global_notices?,trial_badge?,embedded?,load_dashboard_js?), all defaulting to today'sshown-by-default behavior.
Layouts.legacybecomes a thin adapter translating theold
hide_header?/hide_footer?/disable_global_notices?/hide_trial_badge?assigns into the new attrs — no existing call sites change.
_header/_footer/_notice/_flashpartials converted to real functioncomponents (
components/layouts/*.html.heex, viaembed_templates), dropping@connin favor of plain assigns andPlausibleWeb.Endpointfor route helpers.Renamed the billing-notices partial to
team_noticesto avoid colliding withGeneric.notice/1.LayoutView.home_dest/1now takescurrent_userdirectly instead ofconn.Tests
Changelog
Documentation
Dark mode