Optimize CubicBezierShape::find_cross_t - #8413
Open
oscargus wants to merge 1 commit into
Open
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8413-bezieropt View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor out common constants to reduce the number of multiplications. During checking the results (comparing my hand-optimized code with the previous version using AI), the AI pointed out that d is always 0, so I removed that as well.
It is possible to rewrite the equations a bit further, like:
let p = (a / c - h * h);but not sure that it will be beneficial (on superscalar machines) due to introduced data dependencies.
I also have a doubt what will happen when p = 0. I think it may have to be special cased as p = 0 => r = 0 => division by zero (before taking acos).