Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fedramp-faq.md #767

Merged
merged 9 commits into from Jun 11, 2019
Merged

Create fedramp-faq.md #767

merged 9 commits into from Jun 11, 2019

Conversation

@elstudio
Copy link
Collaborator

@elstudio elstudio commented Jun 11, 2019

Create a hidden page from our FedRAMP FAQ content as described here: github/government#448

elstudio added 3 commits Jun 11, 2019
@elstudio
Copy link
Collaborator Author

@elstudio elstudio commented Jun 11, 2019

@jbjonesjr I think this looks ready to roll.

Travis thinks that this page is a broken link (since it exists only on the PR branch, I guess). One day I will look into that.

However today, we have an actual page with FedRAMP copy: https://github-5a58e98664.drafts.github.io/government.github.com/fedramp-faq

/cc @sophshep This is a hidden page, so hopefully I haven't done something too ugly here. :)

/cc @anweiss FYI

@elstudio elstudio marked this pull request as ready for review Jun 11, 2019
Copy link
Collaborator

@jbjonesjr jbjonesjr left a comment

minor nits

fedramp-faq.md Outdated Show resolved Hide resolved
fedramp-faq.md Show resolved Hide resolved
@sophshep
Copy link
Contributor

@sophshep sophshep commented Jun 11, 2019

/cc @sophshep This is a hidden page, so hopefully I haven't done something too ugly here. :)

I've moved over to product design, so I no longer have this site under my AoR. cc/ @github/site-design who can help review!

Copy link
Collaborator Author

@elstudio elstudio left a comment

A little white space never hurt anybody. Thanks for these, @jbjonesjr!

fedramp-faq.md Show resolved Hide resolved
Add white space.

Co-Authored-By: Jamie Jones <[email protected]>
@elstudio elstudio merged commit 62b0e62 into gh-pages Jun 11, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
github/pages GitHub Pages successfully built your site.
Details
@elstudio elstudio deleted the fedramp-faq branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.